[edk2-devel] [PATCH 33/43] OvmfPkg/PciHostBridgeLibScan: remove QEMU (fw_cfg) support

[Philippe Mathieu-Daudé]

On 5/26/21 10:14 PM, Laszlo Ersek wrote:
> The "OvmfPkg/Library/PciHostBridgeLibScan/PciHostBridgeLibScan.inf"
> instance is used in the following platforms in edk2:
> 
>   OvmfPkg/Bhyve/BhyveX64.dsc
>   OvmfPkg/OvmfXen.dsc
> 
> Both platforms define "PcdPciDisableBusEnumeration" with Fixed-at-Build
> access method, and TRUE value. Remove the PCD from the
> PciHostBridgeLibScan instance, and everything else that is useful only
> when the PCD is FALSE.
> 
> In practice, this removes the PciHostBridgeUtilityGetRootBridges()
> function call, which is based on fw-cfg; see
> "OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.c".
> 
> (Note that the dependency on PciHostBridgeUtilityLib remains in place,
> given that the PciHostBridgeLibScan instance continues using lower-level
> functions from the library that do not depend on fw-cfg.)
> 
> Cc: Anthony Perard <anthony.perard at citrix.com>
> Cc: Ard Biesheuvel <ardb+tianocore at kernel.org>
> Cc: Jordan Justen <jordan.l.justen at intel.com>
> Cc: Julien Grall <julien at xen.org>
> Cc: Peter Grehan <grehan at freebsd.org>
> Cc: Philippe Mathieu-Daudé <philmd at redhat.com>
> Cc: Rebecca Cran <rebecca at bsdio.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122
> Signed-off-by: Laszlo Ersek <lersek at redhat.com>
> ---
>  OvmfPkg/Library/PciHostBridgeLibScan/PciHostBridgeLibScan.inf |  7 ---
>  OvmfPkg/Library/PciHostBridgeLibScan/PciHostBridgeLib.c       | 63 +-------------------
>  2 files changed, 2 insertions(+), 68 deletions(-)

Reviewed-by: Philippe Mathieu-Daude <philmd at redhat.com>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#75805): https://edk2.groups.io/g/devel/message/75805
Mute This Topic: https://groups.io/mt/83111003/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-