[edk2-devel] [PATCH] OvmfPkg/PlatformInitLib: fix comment about uncacheable MTRRs

Ard Biesheuvel ardb at kernel.org
Thu Jan 12 10:20:13 UTC 2023


On Thu, 12 Jan 2023 at 08:45, Laszlo Ersek <lersek at redhat.com> wrote:
>
> In commit 49edde15230a ("OvmfPkg/PlatformPei: set 32-bit UC area at
> PciBase / PciExBarBase (pc/q35)", 2019-06-03), I forgot to update the
> comment. Do it now.
>
> Cc: Ard Biesheuvel <ardb+tianocore at kernel.org>
> Cc: Gerd Hoffmann <kraxel at redhat.com>
> Cc: Jiewen Yao <jiewen.yao at intel.com>
> Cc: Jordan Justen <jordan.l.justen at intel.com>
> Fixes: 49edde15230a5bfd6746225eb95535eaa2ec1ba4
> Signed-off-by: Laszlo Ersek <lersek at redhat.com>

Reviewed-by: Ard Biesheuvel <ardb at kernel.org>

Queued up as #3887


> ---
>  OvmfPkg/Library/PlatformInitLib/MemDetect.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/Library/PlatformInitLib/MemDetect.c b/OvmfPkg/Library/PlatformInitLib/MemDetect.c
> index 0c4956852689..882805269b3e 100644
> --- a/OvmfPkg/Library/PlatformInitLib/MemDetect.c
> +++ b/OvmfPkg/Library/PlatformInitLib/MemDetect.c
> @@ -968,7 +968,7 @@ PlatformQemuInitializeRam (
>    //
>    // We'd like to keep the following ranges uncached:
>    // - [640 KB, 1 MB)
> -  // - [LowerMemorySize, 4 GB)
> +  // - [Uc32Base, 4 GB)
>    //
>    // Everything else should be WB. Unfortunately, programming the inverse (ie.
>    // keeping the default UC, and configuring the complement set of the above as


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98357): https://edk2.groups.io/g/devel/message/98357
Mute This Topic: https://groups.io/mt/96218466/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-




More information about the edk2-devel-archive mailing list