[edk2-devel] [PATCH v1 2/4] UefiCpuPkg/PiSmmCpuDxeSmm: Consume SMM Base Hob for SmBase info

[Wu, Jiaxin]

Thanks Gerd, I will refine the code logic.


> -----Original Message-----
> From: Gerd Hoffmann <kraxel at redhat.com>
> Sent: Friday, January 13, 2023 5:51 PM
> To: Wu, Jiaxin <jiaxin.wu at intel.com>
> Cc: devel at edk2.groups.io; Dong, Eric <eric.dong at intel.com>; Ni, Ray
> <ray.ni at intel.com>; Zeng, Star <star.zeng at intel.com>; Laszlo Ersek
> <lersek at redhat.com>; Kumar, Rahul R <rahul.r.kumar at intel.com>
> Subject: Re: [PATCH v1 2/4] UefiCpuPkg/PiSmmCpuDxeSmm: Consume SMM
> Base Hob for SmBase info
> 
>   Hi,
> 
> > +  } else {
> > +    mSmmInitialized = (BOOLEAN *)AllocateZeroPool (sizeof (BOOLEAN) *
> mMaxNumberOfCpus);
> > +    ASSERT (mSmmInitialized != NULL);
> 
> ASSERT is not sufficient error handling.
> 
> take care,
>   Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98467): https://edk2.groups.io/g/devel/message/98467
Mute This Topic: https://groups.io/mt/96241702/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-