[edk2-devel] [PATCH v2] Update CPUID Leaf 06H to follow latest SDM.

[Wang, William2]

OK, I've updated the reserved bit.

Thanks,
William Wang

-----Original Message-----
From: Kuo, Donald <donald.kuo at intel.com> 
Sent: Monday, January 16, 2023 5:23 PM
To: Ni, Ray <ray.ni at intel.com>; Wang, William2 <william2.wang at intel.com>; devel at edk2.groups.io
Cc: Kinney, Michael D <michael.d.kinney at intel.com>; Gao, Liming <gaoliming at byosoft.com.cn>; Kumar, Chandana C <chandana.c.kumar at intel.com>
Subject: RE: [PATCH v2] Update CPUID Leaf 06H to follow latest SDM.

Thanks Ray to clarify.

@Wang, William2 let's follow the EDK2 recommendation.   

Thanks,

-----Original Message-----
From: Ni, Ray <ray.ni at intel.com> 
Sent: Monday, January 16, 2023 5:19 PM
To: Kuo, Donald <donald.kuo at intel.com>; Wang, William2 <william2.wang at intel.com>; devel at edk2.groups.io
Cc: Kinney, Michael D <michael.d.kinney at intel.com>; Gao, Liming <gaoliming at byosoft.com.cn>; Kumar, Chandana C <chandana.c.kumar at intel.com>
Subject: RE: [PATCH v2] Update CPUID Leaf 06H to follow latest SDM.

Donald,
Old code might reference existing Reserved field in the structure definition.
So, to avoid old code assigning value to different bits if using same field name but for different bits position,
edk2 recommends to change the field name from ReservedX to ReservedY when the bits covered by ReservedX are changed. Y is the next unused index.

So comments as below:

> 
> -    UINT32    Reserved5                              : 11;
> 
> +    UINT32    Reserved4                              : 2;
We should rename Reserved5 to Reserved6.


> 
> +    UINT32    IA32_THERM_INTERRUPT                   : 1;
> 
> +    UINT32    Reserved5                              : 7;
Reserved7.



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98633): https://edk2.groups.io/g/devel/message/98633
Mute This Topic: https://groups.io/mt/96250318/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-