[edk2-devel] [PATCH V1 0/3] Fix TDVF issues

[Min Xu]

Thanks for the comments. They're will be sent for review in separate patches.

> -----Original Message-----
> From: Yao, Jiewen <jiewen.yao at intel.com>
> Sent: Monday, January 16, 2023 8:45 AM
> To: Xu, Min M <min.m.xu at intel.com>; devel at edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang at intel.com>; Aktas, Erdem
> <erdemaktas at google.com>; James Bottomley <jejb at linux.ibm.com>; Gerd
> Hoffmann <kraxel at redhat.com>; Tom Lendacky
> <thomas.lendacky at amd.com>; Michael Roth <michael.roth at amd.com>; Yao,
> Jiewen <jiewen.yao at intel.com>
> Subject: RE: [PATCH V1 0/3] Fix TDVF issues
> 
> From process perspective, I see no reason to combine them into one patch set,
> because each patch is individual, and they are handling different problem.
> Also, there is no reason to mix the fix in SecurityPkg with the fix in OvmfPkg, if
> they are not related.
> 
> Please split them into 3 different patches.
> 
> With comment above, reviewed-by: Jiewen Yao <Jiewen.yao at intel.com>
> 
> Thank you
> Yao, Jiewen
> 
> > -----Original Message-----
> > From: Xu, Min M <min.m.xu at intel.com>
> > Sent: Monday, January 16, 2023 7:28 AM
> > To: devel at edk2.groups.io
> > Cc: Xu, Min M <min.m.xu at intel.com>; Yao, Jiewen
> > <jiewen.yao at intel.com>; Wang, Jian J <jian.j.wang at intel.com>; Aktas,
> > Erdem <erdemaktas at google.com>; James Bottomley
> <jejb at linux.ibm.com>;
> > Gerd Hoffmann <kraxel at redhat.com>; Tom Lendacky
> > <thomas.lendacky at amd.com>; Michael Roth <michael.roth at amd.com>
> > Subject: [PATCH V1 0/3] Fix TDVF issues
> >
> > This patch-set fix below TDVF issues:
> > Patch#1: Initialize Status in IoExit
> > Patch#2: Extend EFI boot variable to PCR[1] according to TCG PC Client
> >          PFP spec.
> > Patch#3: Refactor error handle of SetOrClearSharedBit so that the caller
> >          can handle the returned error.
> >
> > Cc: Jiewen Yao <jiewen.yao at intel.com>
> > Cc: Jian J Wang <jian.j.wang at intel.com>
> > Cc: Erdem Aktas <erdemaktas at google.com>
> > Cc: James Bottomley <jejb at linux.ibm.com>
> > Cc: Jiewen Yao <jiewen.yao at intel.com>
> > Cc: Gerd Hoffmann <kraxel at redhat.com>
> > Cc: Tom Lendacky <thomas.lendacky at amd.com>
> > Cc: Michael Roth <michael.roth at amd.com>
> > Signed-off-by: Min Xu <min.m.xu at intel.com>
> >
> > Min M Xu (3):
> >   OvmfPkg/CcExitLib: Initialize Status in IoExit
> >   SecurityPkg/TdTcg2Dxe: Extend EFI boot variable to PCR[1]
> >   OvmfPkg/BaseMemEncryptTdxLib: Refactor error handle of
> >     SetOrClearSharedBit
> >
> >  .../BaseMemEncryptTdxLib/MemoryEncryption.c   | 48 +++++++++++++++---
> -
> >  OvmfPkg/Library/CcExitLib/CcExitVeHandler.c   |  9 ++--
> >  SecurityPkg/Tcg/TdTcg2Dxe/TdTcg2Dxe.c         |  6 +--
> >  3 files changed, 46 insertions(+), 17 deletions(-)
> >
> > --
> > 2.29.2.windows.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98736): https://edk2.groups.io/g/devel/message/98736
Mute This Topic: https://groups.io/mt/96296907/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-