[edk2-devel] [PATCH v3 0/2] BoardModulePkg: BoardBdsHookLib GCC fix
Isaac Oram
isaac.w.oram at intel.com
Thu Jan 19 00:30:18 UTC 2023
Series Reviewed-by: Isaac Oram <isaac.w.oram at intel.com>
-----Original Message-----
From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of Abdul Lateef Attar via groups.io
Sent: Wednesday, January 18, 2023 5:04 AM
To: devel at edk2.groups.io
Cc: Abdul Lateef Attar <AbdulLateef.Attar at amd.com>; Oram, Isaac W <isaac.w.oram at intel.com>; Dong, Eric <eric.dong at intel.com>; Gao, Liming <gaoliming at byosoft.com.cn>
Subject: [edk2-devel] [PATCH v3 0/2] BoardModulePkg: BoardBdsHookLib GCC fix
From: Abdul Lateef Attar <AbdulLateef.Attar at amd.com>
PR : https://github.com/tianocore/edk2-platforms/pull/55/
V3 delta changes:
Addressed below review comments from Isaac Patch 1:
Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c
Line 168: Don't we need to free buffer on this path?
Lines 655, 1083: Please put a newline between while and the block to free resources.
DONE
Patch 2:
edk2-platforms/Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBootOption.c 338:
Can you change to mUefiShellFileGuid and initialize it to zero?
It seems misleading to me to have the default value here when it is not used.
I think we should also move the declarations to the beginning of the file.
DONE
Cc: Oram Isaac W <isaac.w.oram at intel.com>
Cc: Eric Dong <eric.dong at intel.com>
Cc: Liming Gao <gaoliming at byosoft.com.cn>
Abdul Lateef Attar (2):
BoardModulePkg: Copy device path before processing
BoardModulePkg: Adds PCD to load UEFI Shell image
.../Library/BoardBdsHookLib/BoardBdsHookLib.c | 24 +++++++++++----
.../BoardBdsHookLib/BoardBdsHookLib.inf | 3 ++
.../Library/BoardBdsHookLib/BoardBootOption.c | 29 +++++++++----------
.../Intel/MinPlatformPkg/MinPlatformPkg.dec | 5 ++++
4 files changed, 41 insertions(+), 20 deletions(-)
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98834): https://edk2.groups.io/g/devel/message/98834
Mute This Topic: https://groups.io/mt/96352999/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
More information about the edk2-devel-archive
mailing list