[edk2-devel] [PATCH v1 1/1] uefi-sct/SctPkg: Incorrect instances of RANDOM_NAME_PROTOCOL
G Edhaya Chandran
edhaya.chandran at arm.com
Tue Jan 31 15:24:46 UTC 2023
Hi Sunny,
Have already raised a ticket for the remaining 9 instances. These shall be fixed by me:
4328 – Correct instances of RANDOM_NAME_PROTOCOL to RANDOM_NUMBER_PROTOCOL (tianocore.org)<https://bugzilla.tianocore.org/show_bug.cgi?id=4328>
With Warm Regards,
Edhay
From: Sunny Wang <Sunny.Wang at arm.com>
Sent: 31 January 2023 17:25
To: devel at edk2.groups.io; rebecca at bsdio.com; Sam Kaynor <Sam.Kaynor at arm.com>
Cc: G Edhaya Chandran <Edhaya.Chandran at arm.com>; Barton Gao <gaojie at byosoft.com.cn>; Carolyn Gjertsen <Carolyn.Gjertsen at amd.com>; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud at arm.com>; Eric Jin <eric.jin at intel.com>; Arvin Chen <arvinx.chen at intel.com>; Supreeth Venkatesh <Supreeth.Venkatesh at amd.com>; Sunny Wang <Sunny.Wang at arm.com>
Subject: RE: [edk2-devel] [PATCH v1 1/1] uefi-sct/SctPkg: Incorrect instances of RANDOM_NAME_PROTOCOL
Thanks for fixing the issue, Sam.
The change looks good to me. However, I just did a quick search and found 9 instances of "RANDOM_NAME_PROTOCOL". Do we need to also change another 5 instances?
Best Regards,
Sunny
From: devel at edk2.groups.io<mailto:devel at edk2.groups.io> <devel at edk2.groups.io<mailto:devel at edk2.groups.io>> On Behalf Of Rebecca Cran via groups.io
Sent: 30 January 2023 12:16
To: devel at edk2.groups.io<mailto:devel at edk2.groups.io>; Sam Kaynor <Sam.Kaynor at arm.com<mailto:Sam.Kaynor at arm.com>>
Cc: G Edhaya Chandran <Edhaya.Chandran at arm.com<mailto:Edhaya.Chandran at arm.com>>; Barton Gao <gaojie at byosoft.com.cn<mailto:gaojie at byosoft.com.cn>>; Carolyn Gjertsen <Carolyn.Gjertsen at amd.com<mailto:Carolyn.Gjertsen at amd.com>>; Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud at arm.com<mailto:Samer.El-Haj-Mahmoud at arm.com>>; Eric Jin <eric.jin at intel.com<mailto:eric.jin at intel.com>>; Arvin Chen <arvinx.chen at intel.com<mailto:arvinx.chen at intel.com>>; Supreeth Venkatesh <Supreeth.Venkatesh at amd.com<mailto:Supreeth.Venkatesh at amd.com>>
Subject: Re: [edk2-devel] [PATCH v1 1/1] uefi-sct/SctPkg: Incorrect instances of RANDOM_NAME_PROTOCOL
It looks like the cc list wasn't populated correctly.
I've cc'd the people mentioned in the commit message.
On 10/11/22 11:54, Sam Kaynor wrote:
Changed 4 incorrect instances of "RANDOM_NAME_PROTOCOL" in
RandomNumberBBTestConformance and RandomNumberBBTestFunction
to "RANDOM_NUMBER_PROTOCOL".
Cc: G Edhaya Chandran <Edhaya.Chandran at arm.com><mailto:Edhaya.Chandran at arm.com>
Cc: Barton Gao <gaojie at byosoft.com.cn><mailto:gaojie at byosoft.com.cn>
Cc: Carolyn Gjertsen <Carolyn.Gjertsen at amd.com><mailto:Carolyn.Gjertsen at amd.com>
Cc: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud at arm.com><mailto:Samer.El-Haj-Mahmoud at arm.com>
Cc: Eric Jin <eric.jin at intel.com><mailto:eric.jin at intel.com>
Cc: Arvin Chen <arvinx.chen at intel.com><mailto:arvinx.chen at intel.com>
Cc: Supreeth Venkatesh <Supreeth.Venkatesh at amd.com><mailto:Supreeth.Venkatesh at amd.com>
Signed-off-by: Sam Kaynor <sam.kaynor at arm.com><mailto:sam.kaynor at arm.com>
---
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c | 4 ++--
uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c
index 2738a4899457..364aaca925e0 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c
@@ -160,7 +160,7 @@ BBTestGetInfoConformanceTestCheckpoint1 (
StandardLib,
EFI_TEST_ASSERTION_WARNING,
gConformanceTestAssertionGuid001,
- L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() is not supported or EFI_DEVICE_ERROR",
+ L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() is not supported or EFI_DEVICE_ERROR",
L"%a:%d: Status - %r",
__FILE__,
(UINTN)__LINE__,
@@ -180,7 +180,7 @@ BBTestGetInfoConformanceTestCheckpoint1 (
StandardLib,
AssertionType,
gConformanceTestAssertionGuid001,
- L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() returns EFI_BUFFER_TOO_SMALL with small RNGAlgorithmListSize and returns valid size",
+ L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() returns EFI_BUFFER_TOO_SMALL with small RNGAlgorithmListSize and returns valid size",
L"%a:%d: Status - %r, RNGAlgorithmListSize - %d",
__FILE__,
(UINTN)__LINE__,
diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c
index 3d41085d2243..0ba003449dc6 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestFunction.c
@@ -188,7 +188,7 @@ BBTestGetInfoFunctionTestCheckpoint1 (
StandardLib,
EFI_TEST_ASSERTION_FAILED,
gTestGenericFailureGuid,
- L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() is not supported or EFI_DEVICE_ERROR",
+ L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() is not supported or EFI_DEVICE_ERROR",
L"%a:%d: Status - %r",
__FILE__,
(UINTN)__LINE__,
@@ -201,7 +201,7 @@ BBTestGetInfoFunctionTestCheckpoint1 (
StandardLib,
EFI_TEST_ASSERTION_FAILED,
gTestGenericFailureGuid,
- L"RANDOM_NAME_PROTOCOL.GetInfo - GetInfo() could not return the correct RNGAlgorithmListSize",
+ L"RANDOM_NUMBER_PROTOCOL.GetInfo - GetInfo() could not return the correct RNGAlgorithmListSize",
L"%a:%d: Status - %r",
__FILE__,
(UINTN)__LINE__,
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#99352): https://edk2.groups.io/g/devel/message/99352
Mute This Topic: https://groups.io/mt/94264735/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/edk2-devel-archive/attachments/20230131/eb31112a/attachment-0001.htm>
More information about the edk2-devel-archive
mailing list