[edk2-devel] CI passed yesterday; failing today only for PatchCheck

[Michael D Kinney]

Your resync introduced a merge commit:

https://github.com/tianocore/edk2/pull/3969/commits

We do not allow merge commits and only allow linear history.

Please rebase and resubmit.

Mike


> -----Original Message-----
> From: devel at edk2.groups.io <devel at edk2.groups.io> On Behalf Of tlaronde at polynum.com
> Sent: Tuesday, January 31, 2023 1:53 AM
> To: devel at edk2.groups.io
> Subject: [edk2-devel] CI passed yesterday; failing today only for PatchCheck
> 
> As requested, yesterday, for a trivial correction in BaseTools,
> removing useless libuuid dependency in GenFv/, I made a Pull Request
> and triggered a CI check test. All went fine.
> 
> Today, looking if the patches have been reviewed and merged, I saw that
> since the master has changed, it required a merge. I did it and this
> triggered once more a CI check and this time, there is one failure: the
> PatchCheck (required) while everything builds without ado.
> 
> So some questions:
> 
> 1) When a pull request with a CI check test has been made and passed
> successfully, should one simply leave it as is---even if the head
> moves---waiting for reviewer approval and merge?
> 
> 2) Is it known that this procedure (merging and re-trigerring) leads to
> a failure of PatchCheck for whatever reason?
> 
> 3) In my case, the source modification should have impacted only Unix
> like GCC builds: the modification of the GNUmakefile; the removal of
> inclusions that dependend on __FreeBSD__ and __GNUC__ that is only GCC
> related compilations. Is there a way to limit the CI compilation to a
> subset (in this case GCC builds)? Because it seems to me a waste
> of computer time for such a limited modification...
> 
> --
>         Thierry Laronde <tlaronde +AT+ polynum +dot+ com>
>                      http://www.kergis.com/
>                     http://kertex.kergis.com/
> Key fingerprint = 0FF7 E906 FBAF FE95 FD89  250D 52B1 AE95 6006 F40C
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#99354): https://edk2.groups.io/g/devel/message/99354
Mute This Topic: https://groups.io/mt/96649251/1813853
Group Owner: devel+owner at edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [edk2-devel-archive at redhat.com]
-=-=-=-=-=-=-=-=-=-=-=-