[et-mgmt-tools] [PATCH] virt-manager: fix errorpath in domain.py

[Cole Robinson]

Guido Guenther wrote:
> Hi,
> trivial patch against version 0.5.2 for fixing the error path, otherwise
> libvirtError is unknown to the interpreter. Please apply:
> 
> diff --git a/src/virtManager/domain.py b/src/virtManager/domain.py
> index 513f857..323a478 100644
> --- a/src/virtManager/domain.py
> +++ b/src/virtManager/domain.py
> @@ -681,7 +681,7 @@ class vmmDomain(gobject.GObject):
>          try:
>              if self.is_active():
>                  self.vm.attachDevice(xml)
> -        except libvirtError, e:
> +        except libvirt.libvirtError, e:
>              device_exception = str(e)
>  
>          index = vmxml.find("</devices>")
> @@ -703,7 +703,7 @@ class vmmDomain(gobject.GObject):
>          if self.is_active():
>              try:
>                  self.vm.detachDevice(dev_xml)
> -            except libvirtError, e:
> +            except libvirt.libvirtError, e:
>                  device_exception = str(e)
>  
>          # then the stored XML
> 
> Cheers,
>  -- Guido
> 

Hi Guido,

This was actually already fixed in October:

http://hg.et.redhat.com/virt/applications/virt-manager--devel?cs=58c46220f2df

We haven't pushed any updates yet so it is not in Fedora. If you want to
submit patches it is best to base them on upstream. You can find info on this at:

http://virt-manager.et.redhat.com/scmrepo.html

Thanks,
Cole