[et-mgmt-tools] virt-manager os-choice feature

[Hugh Brock]

Daniel P. Berrange wrote:
> On Mon, Feb 19, 2007 at 11:58:16AM -0500, Hugh Brock wrote:
>> Hi everyone.
>>
>> I've just committed a patch that adds UI in virt-manager to control the 
>> "choose your fully virtualized OS" flags in python-virtinst. Details are at
>> http://hg.et.redhat.com/virt/applications/virt-manager--devel?cs=80e0238ab362 
>>
>> At the moment, choosing an OS type affects only the acpi= and apic= 
>> flags, according to a dictionary of those settings in the header of 
>> virtinst/FullVirtGuest. However I imagine we will add more os-dependent 
>> settings later as the occasion arises.
> 
> Looks good, but can you change the two drop down lists to be sorted
> alphabetically :-)
> 
Yeah, good idea... Python does something strange with the list ordering, 
the dictionary is created in alphabetical order, but then it gets either 
reversed or scrambled when it pulls the keys out to put them in the 
model for the pull-down widgets.

Anyway, yeah, I'll sort them...

--H

-- 
Red Hat Virtualization Group http://redhat.com/virtualization
Hugh Brock           | virt-manager http://virt-manager.org
hbrock at redhat.com    | virtualization library http://libvirt.org