[et-mgmt-tools] [PATCH] waiting VNC port number

[Saori Fukuta]

Hi, Dan

Thank you for your comments.

On Wed, 21 Feb 2007 14:11:12 +0000 "Daniel P. Berrange"wrote:
> This is no good because it is Xen specific - the code breaks when used
> with the QEMU / KVM backend to libvirt. I think this is actually a
> combination of two bugs:
> 
>  - libvirt looks in xenstore to find the port number, but if it is
>    missing hardcodes 5900 + domid. So there is a race condition where
>    if virt-install asks for the XML dump, before the framebuffer daemon
>     has started up, it will get the wrong port number. 
> 
>    This is a hardcoded fallback port number is a hangover from old Xen 
>    3.0.2  where the port number was fixed & not kept in xenstore at all. 
>    We need to fix libvirt to only use this code on Xen <= 3.0.3

Yes, I think so, too.
I try to think about how to fix this bug.

>  - Once the above fix in libvirt is done, we can make virt-install do
>    a loop like the one you have below, but instead of looking in xenstore
>    it will look at the port in the XML - waiting for it to change from '-1'
>    to an actual port number

You are right, I will consider again as you pointed out.

Thanks,
Saori Fukuta