[et-mgmt-tools] [PATCH] Redundant checks in Koan's app.py

Michael DeHaan mdehaan at redhat.com
Thu Jul 5 20:08:36 UTC 2007


Adam Rosenwald wrote:
> The run() method for Koan starts off by checking to see if the server 
> attribute is defined.  Later on, in the same method, the same check 
> occurs.  Patch attached to save a clock tick or two... :)
>
> -Adam
>
> --- app.py.orig 2007-07-04 21:56:10.000000000 -0400
> +++ app.py      2007-07-05 15:23:03.000000000 -0400
> @@ -160,8 +160,6 @@
>             raise InfoException, "must use either --virt or 
> --replace-self"
>         if self.is_virt and self.is_auto_kickstart:
>             raise InfoException, "must use either --virt or 
> --replace-self"
> -        if not self.server:
> -            raise InfoException, "no server specified"
>         if self.verbose is None:
>             self.verbose = True
>         if (not self.profile and not self.system):
>
> _______________________________________________
> et-mgmt-tools mailing list
> et-mgmt-tools at redhat.com
> https://www.redhat.com/mailman/listinfo/et-mgmt-tools

Applied, thanks!





More information about the et-mgmt-tools mailing list