[et-mgmt-tools] [PATCH] Unify the checking of the MAC address confliction between virtmanager and virtinstall

Daniel P. Berrange berrange at redhat.com
Tue Jul 10 00:43:06 UTC 2007


On Wed, Jun 27, 2007 at 04:16:53PM +0900, S.Sakamoto wrote:
> Hi,
> 
> Behavior after the check of the repetition of the MAC address of virt-manager(create guest)
> is different from virt-install.
> 
>  *** virt-manager ***
>   After having output warning message "Do you really want to use the MAC address ?",
>   let a user choose behavior with "Yes" or "No".
> 
>  *** virt-install ***
>  In the case of repetition with the MAC address of the host:
>    -> It becomes the error and lets a user input it  MAC address again.
>  In the case of repetition with the MAC address of the another active guest:
>    -> It becomes the error and lets a user input it  MAC address again.
>  In the case of repetition with the MAC address of the another inactive guest:
>    -> After having output warning message, Installation continues.
> 
> Therefore I made the patch which adjusted behavior of virt-manager to virt-install.
> (Because add_hardware is similar Wizard, I make it the same behavior.)
> 
> Incidentally, because items in NIC setting wizard is not initialized, I initialize it.
> 
> Signed-off-by: Shigeki Sakamoto <fj0588di at aa.jp.fujitsu.com>

Looks good to me, I'll apply it.

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 




More information about the et-mgmt-tools mailing list