[et-mgmt-tools] [PATCH] can not specify the type of driver device

[Saori Fukuta]

On Wed, 11 Jul 2007 22:55:38 +0100 "Daniel P. Berrange" wrote:
> > 1) --sub-type
> > The "--sub-type" option that actually I wanted to add is choosing the 
> > mode for operating the disk. As you said, this is just giving the user
> > the ability to specify a sub-type for blktap based files.
> 
> I don't think we want a --sub-type argument - it will almost never be
> used - its not even neccessary for Xen HVM, or QEMU/KVM - its only Xen
> paravirt which ever use it. We should be picking the sub-type automatically 
> based on the disk  format given with the --disk-format arg.

Okey, I understand and thank you for your comment.
So could you close this bugzilla ?
  Bugzilla Bug 246441: can not specify the type of driver device
  URL: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=246441

> > 2) --disk-format
> 
> We need two sets of constants  - DRIVER_TAP_nnn as shown here, but also 
> a seprate set of DISK_FORMAT_nnn constants. There will be pretty much the
> same, except for the DISK_FORMAT_RAW vs DRIVER_TAP_AIO.
>
> For QEMU / KVM, there's no need to specify a disk driver type - QEMU will
> probe & determine the disk format automatically. So this is only ever going
> to be needed for Xen. We can have a simple lookup table mapping disk formats
> to blktap driver type.
> 
>   diskFormatDriverTapSubtype = (
>    DISK_FORMAT_RAW: DRIVER_TAP_AIO,
>    DISK_FORMAT_QCOW: DRIVER_TAP_QCOW,
>    ...
>   )

I can not get to work on adding the above argument immediately, but I 
will try to do as early as possible.

thanks a lot !

Saori.