[et-mgmt-tools] [PATCH] check the existing file in virt-install
Cole Robinson
crobinso at redhat.com
Wed Jul 25 14:19:47 UTC 2007
Masayuki Sunou wrote:
> Hi
>
> When the existing file is specified with virt-install, the file is
> compulsorily overwrited.
> Therefore the important file may be overwrited when a user makes a typo.
>
> This patch fixes so that virt-install displays warning message when
> the existing file is specified.
>
> Signed-off-by: Masayuki Sunou <fj1826dm at aa.jp.fujitsu.com>
>
> Thanks,
> Masayuki Sunou.
Patch looks fine to me. A small nitpick though: I'd change "Do you
really want to use the disk?" to "Do you really want to use this file?"
and add a newline at the start of the line to prevent it from wrapping.
- Cole
--
Cole Robinson
crobinso at redhat.com
More information about the et-mgmt-tools
mailing list