[et-mgmt-tools] VM Images (take 2)

[Daniel P. Berrange]

On Mon, Jul 30, 2007 at 04:37:38PM -0400, Hugh Brock wrote:
> David Lutterkort wrote:
> >Hi,
> >
> >I've updated the patches [1] for virt-inst that deal with machine
> >images. The XML format has changed some since the inital patches. Main
> >changes:
> >
> >      * the os type/variant business has been removed from the XML.
> >        Instead, the features section now allows specifying acpi/apic
> >        directly, e.g. '<acpi state="off"/>' (right now, this requires
> >        some patches [2] to libvirt, too; without them, virt-image will
> >        complain that it can't find a suitable boot descriptor)
> >      * the <disks> section in the <boot> elements has been changed so
> >        that each disk mapping corresponds to a <drive> element instead
> >        of being in <disks>/<map>
> >      * the various hardware info (vcpu, memory, interface, graphics)
> >        are in a devices section
> >      * the <machine> tag is now called <domain>
> >
> >For details of the format, look at the example image.xml, and the
> >Relax-NG grammar, image.rng.
> >
> >David
> >
> >[1] http://people.redhat.com/dlutter/virt-image/
> >[2] https://www.redhat.com/archives/libvir-list/2007-July/msg00395.html
> >
>
> +1, this all looks good. I will commit it unless anyone objects?

The patches are all fine by me - we've reviewed them many times over now
so we should commit this. The only additional thing we need to think about 
now the code is in, is documentation. Of course I'm sure David is on the 
verge of submitting the additional patch to add two man pages 'virt-image.pod'
(describing the command) and 'virt-image.xml.pod' (describing the XML
format).. ;-P

Regards,
Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|