[et-mgmt-tools] [PATCH] cobbler reposync/createrepo bugfixes and enhancements

Michael DeHaan mdehaan at redhat.com
Thu Jun 7 15:20:26 UTC 2007


Perry Myers wrote:
> Patch to some of the python scripts in cobbler to do the following:
>
> 1. There was a bug in action_reposync.py:createrepo_walker that caused createrepo to be run on every subdirectory of the repository being synced.  The core problem was fnames = [] which creates a new list instead of del fnames [:] which modifies the list in place.
> 2. Added a new parameter to repos (--createrepo-flags) to be used for passing useful flags like "-c cache -C -g repodata/comps.xml" when createrepo is called.  This touched a few of the python scripts.
> 3. Modified createrepo in action_import to use the -c cache flag so that future syncs using this repo don't have to regenerate everything.
>
> Please let me know if you have any comments on any of the above changes.
>
> Signed-off-by: Perry Myers (pmyers at redhat.com)
>
> Thanks,
>
> Perry
>
>   

Applied, thanks!

I've also added "-c cache" as a default for the --createrepo-flags 
option, and have updated the manpage.

--Michael




More information about the et-mgmt-tools mailing list