[et-mgmt-tools] VM images

[Daniel P. Berrange]

On Sat, Jun 09, 2007 at 02:51:53PM +0100, Mark McLoughlin wrote:
>   - If you added ImageInstaller support to virt-install, couldn't 
>     virt-image almost just run virt-install rather than re-implementing 
>     a lot of it? i.e. at a glance, it looks like you've forked 
>     virt-install in order to have a version with a simpler command 
>     line. I don't have a problem with virt-image, and the simpler 
>     command line, it's the copied and pasted code I don't like.

Yes I explicitly asked that David do a separate virt-image tool to get us a
simpler command line interface. There is a reasonable amount of duplicate
code - likewise in virt-clone - which we could pull out into the util.py
module, or perhaps another module.

>    - Shouldn't we be copying even system disk images, unless they're 
>      read-only, on instantiation - i.e. you should be able to run 
>      virt-image multiple times.

That's probably a good idea. 

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|