[et-mgmt-tools] [PATCH] Fixes the error when Windows is installedwith "-- os-variant" option

[Hugh Brock]

Masayuki Sunou wrote:
> Hi
> 
> Would you give me a comment on this patch?
> If not, please apply it.
> 
> Thanks,
> Masayuki Sunou.
> 
> In message <200705310829.GAI18261.73KNE29G at aa.jp.fujitsu.com>
>    "[et-mgmt-tools] [PATCH] Fixes the error when Windows is installedwith "-- os-variant" option"
>    "Masayuki Sunou <fj1826dm at aa.jp.fujitsu.com>" wrote:
> 
>> Hi
>>
>> When I install Windows with "-- os-variant" option, virt-install outputs the
>> following errors.
>>
>> --------------------------------------------------------------------------------
>> # virt-install --name TEST --ram 256 --vnc --hvm --cdrom /mnt/WinSrv2k3sp1/Win2003_Sp1.iso
>>  --os-type="windows" --os-variant="win2k" --file /dev/sda8
>>
>> Starting install...
>> libvir: Xen Daemon error : GET operation failed: 
>> Domain installation may not have been
>> successful.  If it was, you can restart your domain
>> by running 'virsh start TEST'; otherwise, please
>> restart your installation.
>> Wed, 30 May 2007 13:05:57 ERROR    'distro'
>> Traceback (most recent call last):
>>   File "/usr/bin/virt-install", line 647, in <module>
>>     main()
>>   File "/usr/bin/virt-install", line 607, in main
>>     dom = guest.start_install(conscb,progresscb)
>>   File "/usr/lib/python2.5/site-packages/virtinst/Guest.py", line 668, in start_install
>>     self._prepare_install(meter)
>>   File "/usr/lib/python2.5/site-packages/virtinst/FullVirtGuest.py", line 195, in _prepare_install
>>     distro = self.os_distro)
>>   File "/usr/lib/python2.5/site-packages/virtinst/FullVirtGuest.py", line 148, in get_os_distro
>>     return FullVirtGuest.OS_TYPES[self.os_type]["variants"][self.os_variant]["distro""]
>> KeyError: 'distro'
>> --------------------------------------------------------------------------------
>>
>> This patch fixes it.
>>
>>
>> Signed-off-by: Masayuki Sunou <fj1826dm at aa.jp.fujitsu.com>
>>
>> Thanks,
>> Masayuki Sunou.
>>
Sorry for the delay. Patch looks good, I have applied it.

--Hugh

-- 
Red Hat Virtualization Group http://redhat.com/virtualization
Hugh Brock           | virt-manager http://virt-manager.org
hbrock at redhat.com    | virtualization library http://libvirt.org