[et-mgmt-tools] [PATCH] virt-manager error msg fixup
Hugh Brock
hbrock at redhat.com
Wed Jun 13 21:18:05 UTC 2007
Cole Robinson wrote:
> The error message that pops up when the user tries to enter an invalid
> guest name doesn't correctly list valid name characters (it was missing
> the '-').
>
> Thanks,
> Cole
>
>
Applied, thanks!
However: What we really want to do here is stop validating this stuff in
virt-manager at all. We have validation both in virt-manager and
virtinst and in a couple of places it disagrees... grr... What we should
really do is abstract this kind of validation into virtinst/util.py I
think, that way we have only one regex.
If you want to have a crack at that, please be my guest...
--Hugh
--
Red Hat Virtualization Group http://redhat.com/virtualization
Hugh Brock | virt-manager http://virt-manager.org
hbrock at redhat.com | virtualization library http://libvirt.org
More information about the et-mgmt-tools
mailing list