[et-mgmt-tools] [PATCH] Fix the maximum number of VCPUin virt-manager

Hugh Brock hbrock at redhat.com
Mon Jun 18 19:17:10 UTC 2007

Masayuki Sunou wrote:
> Hi Hugh
> Thank you for reviewing.
> I remake this patch.
>> Hmm, this is good, but I'm inclined to think it would be better to put a 
>> getMaxVcpus() call in connection.py and isolate the "check the 
>> connection type and either call getMaxVcpus or arbitrarily return '32'" 
>> there (so we don't repeat the code in two places). Also, it looks to me 
>> like "Xen" is the default in xen_unified.c, at least in current libvirt 
>> code, so you shouldn't need to supply "Xen" to the getMaxVcpus call. Can 
>> you redo the patch along these lines?
> This patch changes as follows.
>  1. getMaxVcpus() is executed from connection.py.
>  2. getMaxVcpus() is called with the result of get_type() not "Xen" 
> Thanks,
> Masayuki Sunou.
Thanks, I have applied this!


Red Hat Virtualization Group http://redhat.com/virtualization
Hugh Brock           | virt-manager http://virt-manager.org
hbrock at redhat.com    | virtualization library http://libvirt.org

More information about the et-mgmt-tools mailing list