[et-mgmt-tools] [PATCH] virtinst error message improvements

Hugh Brock hbrock at redhat.com
Thu Jun 21 17:25:51 UTC 2007

Cole Robinson wrote:
> Cole Robinson wrote:
>> Hi all,
>> Attached is a patch that cleans up and improves some error reporting 
>> in virtinst. Includes error checking for setting memory and vcpu, 
>> improved install location and disk location errors, and a couple other 
>> fixes.
>> Signed-off-by: Cole Robinson <crobinso at redhat.com>
>> Thanks,
>> Cole
> I managed to slip in a small bug when tidying up the patch to send out. 
> I thought I tested it but apparently not! Attached is the fixed patch.
> Thanks, Cole

This looks good on first glance; I'll test it this afternoon.

One of the BZs we had on the guest name issue requested that we allow 
"." in guest names as well. Does anyone know if that is legal for Xen? 
If so, we should add that character to the regex as well.


Red Hat Virtualization Group http://redhat.com/virtualization
Hugh Brock           | virt-manager http://virt-manager.org
hbrock at redhat.com    | virtualization library http://libvirt.org

More information about the et-mgmt-tools mailing list