[et-mgmt-tools] [PATCH] virt-manager validation and error reporting improvements

Cole Robinson crobinso at redhat.com
Fri Jun 22 14:54:14 UTC 2007

Cole Robinson wrote:
> Hugh Brock wrote:
>> Needed to change "guest.os_type" to "self._guest.os_type" here and 
>> below, works fine with that change.
> Your comment was actually at the removed portion of the code so I was 
> confused for a minute, but yes, definitely change that.
>> NIT: Seems silly to copy the entire self._guest object here merely so 
>> you can hang onto the name. Why not just "name = 
>> self._guest.get_name()" followed later by "self._guest.name = name"?
> Whoops, good call.
>> Otherwise looks pretty good. If you agree to the changes above I will 
>> apply it.
> I agree, apply at will. :)
> Thanks,
> Cole

Since we found some other errors, here's the (hopefully) final 
incarnation of this patch.

Signed-off-by: Cole Robinson <crobinso at redhat.com>


Cole Robinson
crobinso at redhat.com
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: virt-manager-validation-03-patch
URL: <http://listman.redhat.com/archives/et-mgmt-tools/attachments/20070622/3d9eda52/attachment.ksh>

More information about the et-mgmt-tools mailing list