[et-mgmt-tools] [PATCH] virtinst error message improvements

[Cole Robinson]

Hugh Brock wrote:
> Cole Robinson wrote:
>> Cole Robinson wrote:
>>>
>>> Hi all,
>>>
>>> Attached is a patch that cleans up and improves some error reporting 
>>> in virtinst. Includes error checking for setting memory and vcpu, 
>>> improved install location and disk location errors, and a couple 
>>> other fixes.
>>>
>>> Signed-off-by: Cole Robinson <crobinso at redhat.com>
>>>
>>> Thanks,
>>> Cole
>>>
>>>
>>
>> I managed to slip in a small bug when tidying up the patch to send 
>> out. I thought I tested it but apparently not! Attached is the fixed 
>> patch.
>>
>> Thanks, Cole
>>
> 
> This looks good on first glance; I'll test it this afternoon.
> 
> One of the BZs we had on the guest name issue requested that we allow 
> "." in guest names as well. Does anyone know if that is legal for Xen? 
> If so, we should add that character to the regex as well.
> 
> Thanks,
> --Hugh
> 

I verified that xen doesn't complain about a '.' in the guest name, so I 
added that to the patch and changed a few error messages to be more clear.

Signed-off-by: Cole Robinson <crobinso at redhat.com>

Thanks,
Cole

-- 
Cole Robinson
crobinso at redhat.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: virtinst-validation-02.patch
Type: text/x-patch
Size: 10496 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/et-mgmt-tools/attachments/20070622/e4e223b7/attachment.bin>