[et-mgmt-tools] [PATCH][RESEND] connecting console after install completes

[Hugh Brock]

Nobuhiro Itou wrote:
> Hi, Dan
> 
> Would you give me a comment on this patch?
> If not, please apply it.
> 
>> When the domain restarts after install completes, the console is not connected.
>> Therefore, if I don't connect the console for myself, 
>> I cannot be finished the setting after install completes.
>>
>> The attached patch adds to solve this problem.
>>
>>
>> Signed-off-by: Nobuhiro Itou <fj0873gn at aa.jp.fujitsu.com>
> 
> 
> Thanks,
> Nobuhiro Itou.
> 

Two issues here:

1. The whole "restart the guest automatically" feature in virt-install 
is a bit of a hack, and we are contemplating removing it altogether. The 
problem is that virt-install has no real way of knowing whether the 
guest that just shut down is really waiting to be rebooted, or is in 
fact a failed install that the user would not want restarted anyway. 
Having said this, as long as the "restart" hack is still there, I guess 
I have no problem reconnecting the console as well.

2. Minor nit: instead of swallowing the error like

+            except OSError, (errno, msg):
+                print __name__, "waitpid:", msg

why not go ahead and raise a RuntimeError (and log the message) or 
something similar?

If you want to fix 2. and resubmit, I'll go ahead and apply it.

Thanks!

--Hugh

-- 
Red Hat Virtualization Group http://redhat.com/virtualization
Hugh Brock           | virt-manager http://virt-manager.org
hbrock at redhat.com    | virtualization library http://libvirt.org