[et-mgmt-tools] [PATCH] Check the making domain's disk sources

Daniel P. Berrange berrange at redhat.com
Thu Mar 15 12:15:04 UTC 2007


On Thu, Mar 15, 2007 at 05:45:26PM +0900, Tatsuro Enokura wrote:
> Hi,
> 
> The virt-install command specify the Domain's disk sources.
> But the virt-install command doesn't check that the disk sources are
> conflicted among the other domains.
> 
> The attached patch resolve this issue in the following way:
> 
>   1) Count that the making domian's disk src is already use
>      the exists domain's disk source.
>   2) if count > 0, print confirmation message.
>   3) if type yes then leave disk source as it is,
>      else ask disk source again.
> 
> I am making a patch for virt-manager about this issue.

If you the non-interactive bit of code into the virtinst/Guest.py module
in the VirtualDisk class, we can share 95% of it between both virtinstall 
& virt-manager.

Regards,
Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 




More information about the et-mgmt-tools mailing list