[et-mgmt-tools] [PATCH] fix VNC connection errors in virt-manager

Charles Coffing ccoffing at novell.com
Wed May 2 20:28:34 UTC 2007

There is a nasty typo in virt manager, which is masked by a catch-all "except:" clause.  This error could cause unnecessary VNC connection failures.

The bad line is actually completely useless, since disconnect_from_host correctly sets self.client=None.  The preceeding "if" is also useless, since disconnect_from_host handles the case where self.client is None.  The attached patch deletes all this unnecessary junk.

Signed-off-by: Charles Coffing <ccoffing at novell.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: virtman-typo.diff
Type: application/octet-stream
Size: 672 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/et-mgmt-tools/attachments/20070502/209b7485/attachment.obj>

More information about the et-mgmt-tools mailing list