[et-mgmt-tools] [PATCH] Add VNC-Port setting when virt-manager creates VM

[Daniel P. Berrange]

On Fri, May 18, 2007 at 07:05:13PM +0900, S.Sakamoto wrote:
> Hi,
> 
> The attached patch adds VNC-Port setting when virt-manager creates VM.
> The user can choose whether a VNC-Port is fixed or automatic setup. 

I don't think we want to expose ability to specify a fixed VNC port numbers 
in virt-manager. It will prove unreliable in practice, because even if you
fix a particular guest on port 5905, any other guest doing dynamic VNC port
assignment may choose this port before the hardcoded guest starts. It is
not going to be easy for virt-manager to do validation of this port number
either, since in the near future virt-manager may well be running remotely
from the host. Finally, any one using virt-manager for management of guests
never needs to know the port number, since virt-manager will always query
it from the XML, so this is a very small niche usecase & I don't think it
is worthwhile adding an extra step in the new VM wizard just for this
capability.

Regards,
Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|