[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [et-mgmt-tools] [PATCH] Fix virtinst logging



On Tue, May 29, 2007 at 04:59:09PM +0900, Nobuhiro Itou wrote:
> Hi,
> 
> I corrected the following about the virtinst log.
> - Changing from "print >> sys.stderr" to "logging.error".
> - Default logging level is changed from ERROR to WARNING.
> - Adding to output optional and interactive information to the log file only.

Hmm. I'm not to sure about this change. It is basically feedback for user
input go via the logging sub-system, instead of directly displaying on
stderr. This means that if someone ever changed the logging setup, these
important user interaction prompt could belost. At the same time, I understand
why you want to make this change - to capture more info in the logfiles.
I think that instead of replaces 'print >> sys.stderr' with 'logging.error'
we should leave the 'print >> sys.stderr' statements as they currently
are, and *add* extra calls to 'logging.error' at the same places in the code
(or as needed). So important user interaction still goes directly to
sys.stderr, but we also log the information at the same time.

Regards,
Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]