[et-mgmt-tools] cobbler git: multiple interface system edit cleanup

[Al Tobey]

Now with attachments!

On 11/6/07, Al Tobey <tobert at gmail.com> wrote:
> On 11/5/07, Michael DeHaan <mdehaan at redhat.com> wrote:
> > Al Tobey wrote:
> > > I got distracted by the multiple interface system edit screen and
> > > decided to clean it up a bit.   A patch and partial screenshot are
> > > attached.
> > Nice...
> >
> > I do like the boxes and not repeating the tooltips for the later interfaces.
> >
> > > The javascript is a lot less complex.   The screen looks a lot more
> > > useable for the common case now.    The help text is hidden for
> > > interfaces > 0, which saves a ton of vertical space.   Each interface
> > > is in its own fieldset element now, which groups it better IMO.
> > > Configured interfaces are displayed by default.
> > >
> > > I took out the image-based +/- for now, but it can go back if people
> > > really like it better.   I only changed it to simplify things while
> > > hacking.  Most of the stuff in cobbler.js can go away if this approach
> > > is taken instead.
> > >
> >
> > Well, Cobbler.js is going to stay.   The point is to get the javascript
> > code pulled out of the templates
> > as much as possible, so it can be read all in one place, and we don't
> > have things copy/pasted everywhere
> > when they are more generically useful.  Ideally the javascript code in
> > this patch would be moved there.
> >
> > A few things I'd like to see done before I can apply this:
> >
> > -- Have you tested this in MSIE?
> > -- Put back the +/- graphics
> > -- Fix mixed tabs/spaces
>
> New patch attached.
>
> I only tested IE7 which was horribly broken.   I think the <hr/>'s
> were defaulting to width="100%" or something, making the left nav bar
> width 100%.   I forced the div containing the nav bar to 200px in the
> CSS which seems to have brought it under control.
>
> -Al
>
> >
> > Thanks!
> >
> > --Michael
> >
> >
> > > -Al
> > >
> > > ------------------------------------------------------------------------
> > >
> > > ------------------------------------------------------------------------
> > >
> > > _______________________________________________
> > > et-mgmt-tools mailing list
> > > et-mgmt-tools at redhat.com
> > > https://www.redhat.com/mailman/listinfo/et-mgmt-tools
> >
> > _______________________________________________
> > et-mgmt-tools mailing list
> > et-mgmt-tools at redhat.com
> > https://www.redhat.com/mailman/listinfo/et-mgmt-tools
> >
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Rework-system-edit-webui-screen.patch
Type: text/x-patch
Size: 24183 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/et-mgmt-tools/attachments/20071106/efc753ea/attachment.bin>