[et-mgmt-tools] [PATCH] virt-manager: log uncaught exceptions

Cole Robinson crobinso at redhat.com
Wed Nov 14 21:14:51 UTC 2007


Hugh O. Brock wrote:
> On Wed, Nov 14, 2007 at 01:13:13PM -0500, Cole Robinson wrote:
>> The attached patch alters sys.excepthook to log uncaught exceptions.
>> Currently in virt-manager.py the main() call is wrapped in a try...except
>> block that was assumed to log uncaught exceptions, but the gtk.main() loop
>> does not raise exceptions (hence why the app does not crash anytime an
>> exception is uncaught).
>>
>> Info on this was found here:
>> http://faq.pygtk.org/index.py?req=show&file=faq20.010.htp
>>
>> Any comments welcome.
>>
>> - Cole
>>
> +1 this will help a lot with all those "virt-manager exits for no reason" BZs...
> 
> --H
> 

I just committed this:

http://hg.et.redhat.com/virt/applications/virt-manager--devel?cs=9da820df4011

- Cole

-- 
Cole Robinson
crobinso at redhat.com




More information about the et-mgmt-tools mailing list