[et-mgmt-tools] [PATCH]: Make virt-viewer ungrab the mouse and keyboard on un-focus

[Daniel P. Berrange]

On Tue, Apr 22, 2008 at 10:43:08AM -0400, Chris Lalancette wrote:
> Chris Lalancette wrote:
> > The attached patch prevents this situation by doing a forced ungrab when we get
> > a focus-out-event from GTK.
> > 
> > Signed-off-by: Chris Lalancette <clalance at redhat.com>
> 
> Any interest in this patch?

I struggle to understand how/what you managed todo here. If the keyboard
grab is active nothing should be able to steal keyboard input focus, since
this is the whole point of keyboard grab. If something did manage to steal
keyboard input while grab was active, then this is a bug in the window
manager and not something we should hack in virt-viewer - inded if this
is possible, then every single app which uses grabs needs your patch which
is clearly non-scalable

Dan.
-- 
|: Red Hat, Engineering, Boston   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|