[et-mgmt-tools] [PATCH] report block size in add hardware summary

Cole Robinson crobinso at redhat.com
Sun Aug 3 18:09:21 UTC 2008


Adam Stokes wrote:
> The way virt-manager is setup now is that it only reports sizes of file
> backed images and a "-" with storage partitions.

I'm fine with the idea, however this patch needs a bit of work.

First this will need to be duplicated in create.py for the 
guest creation wizard. I'd recommend breaking it out into
it's own function as well so we don't start adding a lot
of logic to the relatively simple get_config_* functions.

Also, could you wrap this code in a try...except block, just
log an error if we can't detect the size, and return None.

> 
> This patch addresses that issue.
> 
> I'll be filing a bug for RHEL5 as soon as bugzilla comes out of
> maintenance mode
> 

Actually could you just bring this up in bz 453061? It's basically
covering the same issue.

Thanks,
Cole






More information about the et-mgmt-tools mailing list