[et-mgmt-tools] [PATCH] virtinst: Remove most prompting from virt-* tools

[Cole Robinson]

The attached patch removes most parameter prompting from
the virt command line tools. I think any usefulness they
once had is largely gone, and they are becoming a maintainance
burden. This burden is even more apparent trying to
update this stuff to accommodate remote installs.

Currently, if not specified, we prompt for:

  vm name (will now fail if not specified)
  vm ram  (will now fail if not specified)
  install media (this is a real pain now. originally the
                 install type matrix was far simpler, so
                 abstracting what type of media the user
                 'really' means is actually impossible
                 in some cases from this prompt)
  pv vs. hvm (this was actually dropped in last release)
  enable vnc (should just default to vnc if display is set,
              nographics otherwise)
  disk path  (will now fail, and inform user they need to
              specify --nodisks if they don't want storage)
  disk size, if disk doesn't exist (will now fail)

There are also some yes/no prompts to keep users from
shooting themselves in the foot

  sparse disk max size exceeds physical disk capacity
  specified more vcpus than physical cpus
  
I say we leave these in. I think these are generally useful,
and any automated virt-install commands should use --force
anyways. I've tried to test all the above cases and it
seems to work as expected.

Any feedback appreciated, wondering what people think about
this.

Thanks,
Cole

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: virtinst-remove-prompting-patch
URL: <http://listman.redhat.com/archives/et-mgmt-tools/attachments/20080801/1138b911/attachment.ksh>