[et-mgmt-tools] [PATCH] virtinst: also look at xorg.conf for keymap

[Guido Günther]

On Mon, Dec 01, 2008 at 10:28:15AM -0500, Cole Robinson wrote:
> > +    import keytable
> 
> This is unused ('python setup.py check' will warn about this :)
Fixed.
> 
> > +    kt = None
> > +    try:
> > +        f = open(XORG_CONF, "r")
> > +    except IOError, e:
> > +        logging.debug('Could not open "%s": %s ' % (XORG_CONF, str(e)))
> > +    else:
> > +        keymap_re = re.compile(r'\s*Option\s+"XkbLayout"\s+"(?P<kt>[a-z-]+)"')
> > +        for line in f:
> > +            m = keymap_re.match(line)
> > +            if m:    
> > +                kt = m.group('kt')
> > +                break
> > +        else:
> > +            logging.debug("Didn't find keymap '%s' in keytable!" % kt)
> 
> This logging isn't really accurate here. Maybe 'Didn't find keymap in
> xorg.conf'
Yes, that's bogus. Fixed version attached.
 -- Guido
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xorg-keymap.diff
Type: text/x-diff
Size: 2339 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/et-mgmt-tools/attachments/20081201/73bd8e8b/attachment.bin>