[et-mgmt-tools] [PATCH] Fix lookup pool by path
crobinso at redhat.com
Wed Dec 3 16:21:47 UTC 2008
Andreas Schneider wrote:
> On Monday 01 December 2008 16:07:45 Cole Robinson wrote:
>> Hmm, so your pool xml lists the target directory with a trailing slash?
>> I'm not seeing that. What version of libvirt are you using, and can you
>> provide the pools xml?
> I'm using virt-manager to connect to a remote host, so if I create a pool I
> have to specify the path to the pool manually.
> This means you can enter as many trailing slashes as you want. So the
> questions is, should the slashes be stripped during the creation of the pool
> <pool type='dir'>
Hmm, yes, seems like libvirt should be sanitizing the target path when
the pool is defined (though virtinst could certainly do this too).
Looks like there could be arbitrary '/' in the middle of the path
though, so if you use something like os.path.abspath in your patch it
should sanitize everything appropriately.
More information about the et-mgmt-tools