[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [et-mgmt-tools] [PATCH] Use netcat if found



On Mon, Dec 01, 2008 at 10:12:52AM -0500, Cole Robinson wrote:
> Andreas Schneider wrote:
> > Hi,
> > 
> > attached is a patch for virt-manager to use the netcat binary instead of nc if 
> > it is found.
> > 
> > 
> > Cheers,
> > 
> > 
> > 	-- andreas
> > 
> 
> I'd rather keep things operating the same if 'nc' is present, which
> would mean using 'netcat' only if 'nc' isn't available. Is there a
> reason we should prefer netcat over nc, or is it just that your distro
> provides one and not the other?

This used to be the case with Debian/Ubuntu, but they now provide the
'nc' binary too. In addition the 'netcat' binary they also ship does
not work with libvirt since it doesn't support UNIX sockets. 

Finally the patch is wrong because its doing

+            if os.path.exists('/usr/bin/netcat'):
+                netcat = "netcat"

which is in the context of the machine virt-manager is running on, which
is totally bogus when connecting to a remote machine.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]