[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [et-mgmt-tools] [PATCH] virtinst: also look at xorg.conf for keymap



Cole Robinson wrote:
> Guido Günther wrote:
>> Hi,
>> attached patch looks at xorg.conf if no /etc/sysconfig/keyboard for the
>> default keyboard. This helps with distros that don't have
>> /etc/sysconfig/ like Debian.
>> Cheers,
>>  -- Guido
>>
> 
> Couple small nits:
> 
>>  HG changeset patch
>> # User Guido Günther <agx sigxcpu org>
>> # Date 1227979760 -3600
>> # Node ID a292eb8430cd2d9544e89dba127323704f3963ce
>> # Parent  16e923676e84d81cf9bf6dc2cdd30d95bf65bbe1
>> parse xorg.conf for keymap
>>
>> diff -r 16e923676e84 -r a292eb8430cd virtinst/util.py
>> --- a/virtinst/util.py	Tue Nov 25 10:25:08 2008 -0500
>> +++ b/virtinst/util.py	Sat Nov 29 18:29:20 2008 +0100
>> @@ -33,6 +33,7 @@
>>  
>>  
>>  KEYBOARD_DIR = "/etc/sysconfig/keyboard"
>> +XORG_CONF = "/etc/X11/xorg.conf"
>>  
>>  def default_route():
>>      route_file = "/proc/net/route"
>> @@ -276,6 +277,28 @@
>>              return -1
>>      return 0
>>  
>> +def xorg_keymap():

One other thing: could you rename this to _xorg_keymap so it isn't
confused for a public function?

Thanks,
Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]