[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[et-mgmt-tools] [PATCH] virtinst: remove bashisms from tests/pylint-virtinst.sh



Hi,
the script uses /bin/sh so "function" mustn't be used. Patch attached.
Cheers,
 -- Guido
# HG changeset patch
# User Guido Günther <agx sigxcpu org>
# Date 1228156919 -3600
# Node ID 68c036763c41caebafd3c759325c84f7453fccc3
# Parent  0a953a339693bf41435f6b147fd1ea4944d5bf77
Remove bashisms since we use /bin/sh which is not always bash (it's dash on
Debian)

diff -r 0a953a339693 -r 68c036763c41 tests/pylint-virtinst.sh
--- a/tests/pylint-virtinst.sh	Sat Nov 29 18:39:05 2008 +0100
+++ b/tests/pylint-virtinst.sh	Mon Dec 01 19:41:59 2008 +0100
@@ -48,12 +48,12 @@
 UNUSED_ARGS="SuseDistro.isValidStore.*Unused argument 'progresscb'|LiveCDInstaller.prepare.*Unused argument|ImageInstaller.prepare.*Unused argument|post_install_check.*Unused argument 'guest'|Guest.__init__.*Unused argument 'type'"
 
 DMSG=""
-function addmsg {
+addmsg() {
     DMSG="${DMSG},$1"
     }
 
 DCHECKERS=""
-function addchecker {
+addchecker() {
     DCHECKERS="${DCHECKERS},$1"
 }
 

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]