[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [et-mgmt-tools] [PATCH] Fix lookup pool by path



Andreas Schneider wrote:
> On Wednesday 03 December 2008 17:21:47 Cole Robinson wrote:
>   
>>
>> Hmm, yes, seems like libvirt should be sanitizing the target path when
>> the pool is defined (though virtinst could certainly do this too).
>>
>> Looks like there could be arbitrary '/' in the middle of the path
>> though, so if you use something like os.path.abspath in your patch it
>> should sanitize everything appropriately.
>>     
>
> Thanks, this was the function I was looking for. I've attached an updated 
> patch. I think it should be fixed in libvirt and virt-manager. Just to be sure 
> that you can't run into the problem again.
>   

Agreed on the above point. I've committed your fix now:

http://hg.et.redhat.com/virt/applications/virtinst--devel?cs=b66d39a23988

Thanks for the contribution!

- Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]