[et-mgmt-tools] Re: [PATCH] virtinst use .treeinfo for OS type detection files path

Daniel P. Berrange berrange at redhat.com
Sat Feb 16 18:36:19 UTC 2008


On Thu, Feb 14, 2008 at 11:30:22AM +0100, Alexander Todorov wrote:
> Daniel P. Berrange wrote:
> > It does look very promising - its definitely something we should try to
> > make use of in virt-install as it ought to make us more robust wrt to
> > future changes. If anyone's interested in supplying patches to make use of
> > the .treeinfo files, please send them to the list, otherwise we'll consider 
> > this a TODO item for our development roadmap.
> > 
> Here's a completely UNTESTED patch.
> The .treeinfo file is available in Fedora and will be available for RHEL 5.2 and
> later and probably CentOS 5.2 as well.
> Fall backs to old code are still in place.

I tested it against Fedora and it works great, so I've committed this.

BTW, please just use spaces and not tabs for patches - python complained
about inconsistent indentation due to the tabs.

Regards,
Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 




More information about the et-mgmt-tools mailing list