[et-mgmt-tools] [PATCH] convert vmware machines to virt-image xml format

[Daniel P. Berrange]

On Tue, Jul 01, 2008 at 07:01:33AM -0400, Bryan Kearney wrote:
> Daniel P. Berrange wrote:
> >On Tue, Jul 01, 2008 at 04:48:47AM +0100, John Levon wrote:
> >>On Mon, Jun 30, 2008 at 08:14:55PM -0700, David Lutterkort wrote:
> >>
> >>>>>--- virtinst--devel.orig/virt-unpack	1969-12-31 
> >>>>>19:00:00.000000000 -0500
> >>>>>+++ virtinst--devel/virt-unpack	2008-06-26 10:30:45.000000000 -0400
> >>>>Why isn't this called virt-convert? I don't see any actually "unpacking"
> >>>>going on here.
> >>> 
> >>>Calling it virt-pack is more a historical accident. I think renaming it
> >>>to virt-convert makes sense. It'll require some small changes in the
> >>>command line switches though, so you cna say from what format and to
> >>>what format you want to convert.
> >>Indeed. I have some comments on that too. What I'd like to see is
> >>something like the logic below. I may even be sending patches to do
> >>this, if I can get some consensus.
> >>
> >>virt-convert [-i ifmt] -o ofmt input [output]
> >
> >[snip rest of example]
> >
> >
> >I think this makes alot of sense - it is definitely important to have the 
> >command line syntax support multiple formats, even if we've only got an
> >impl for vmware so far.
> >
> >Daniel
> 
> Will the sniffing work for anything but vmware files? I rather it be 
> explicit in all cases unless we can infer them all.

Yes, there is magic header that lets you detect pretty much all types
of disk image file - see the 'qemu-img' command. 

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|