[et-mgmt-tools] [PATCH] Check result of qemu-img

John Levon levon at movementarian.org
Tue Jul 1 19:24:36 UTC 2008


Check result of qemu-img

If qemu-img convert fails, report an error and exit.

Signed-off-by: John Levon <john.levon at sun.com>

diff --git a/virt-unpack b/virt-unpack
--- a/virt-unpack
+++ b/virt-unpack
@@ -237,8 +237,9 @@ def convert_disks(disks_list, options):
         if not os.path.isabs(outfile):
             outfile = os.path.join(options.output_dir, outfile)
         convert_cmd="qemu-img convert %s -O raw %s" % (infile, outfile)
-        ret = os.system(convert_cmd)
-        print ret
+        if os.system(convert_cmd) != 0:
+            logging.error("Converting disk %s failed.\n" % infile)
+            sys.exit(1)
 
 
 def main():




More information about the et-mgmt-tools mailing list