[et-mgmt-tools] [PATCH] Make lack of 'numvcpus' a warning only

[Daniel P. Berrange]

On Tue, Jul 01, 2008 at 08:25:29PM +0100, John Levon wrote:
> 
> Make lack of 'numvcpus' a warning only
> 
> A .vmx file without 'numvcpus' seems common. Make the warning be a
> debug-only message.
> 
> Signed-off-by: John Levon <john.levon at sun.com>
> 
> diff --git a/virt-unpack b/virt-unpack
> --- a/virt-unpack
> +++ b/virt-unpack
> @@ -119,7 +119,7 @@ def vmx_to_image_xml(disks_list,record,o
>      if record.has_key("numvcpus"):
>          vcpus = record["numvcpus"]
>      else:  
> -        logging.error("numvcpus key not parsed from %s, defaulting to 1 virtual cpu" % file)
> +        logging.warning("numvcpus key not parsed from %s, defaulting to 1 virtual cpu" % file)
>          vcpus = "1"

IMHO, we shoudn't bother logging anything just silently default
it to 1.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|