[et-mgmt-tools] [PATCH] virt-convert: arch is required

Cole Robinson crobinso at redhat.com
Wed Jul 2 14:48:08 UTC 2008


John Levon wrote:
> Fix usage message
> 
> The -a option is required; reflect this in the help message.
> 
> Signed-off-by: John Levon <john.levon at sun.com>
> 
> diff --git a/virt-convert b/virt-convert
> --- a/virt-convert
> +++ b/virt-convert
> @@ -30,7 +30,7 @@ from optparse import OptionParser
>  
>  def parse_args():
>      parser = OptionParser()
> -    parser.set_usage("%prog [options] inputdir|input.vmx "
> +    parser.set_usage("%prog [options] -a arch inputdir|input.vmx "
>          "[outputdir|output.xml]")
>      parser.add_option("-a", "--arch", type="string", dest="arch",
>                        help=("Machine Architecture Type (i686/x86_64/ppc)"))
> 

I realize this is just a docs change but we probably shouldn't require
arch to be specified. Seems sensible just to default to the host arch
if it is in some supported whitelist.

- Cole




More information about the et-mgmt-tools mailing list