[et-mgmt-tools] [PATCH 2/2] virtinst: add --sound option to virt-install

[Daniel P. Berrange]

On Wed, Jul 09, 2008 at 11:21:39AM -0400, Cole Robinson wrote:
> In virt-install I added a boolean --sound option which defaults
> to adding the es1370 device, which seems to be sufficient for
> most modern distros. I'm not sure if this option should be
> adjusted to allow the user to specify sound models but it seems
> like added complexity for an undetermined use case.

> @@ -405,6 +406,7 @@
>      cli.get_memory(options.memory, guest)
>      cli.get_uuid(options.uuid, guest)
>      cli.get_vcpus(options.vcpus, options.check_cpu, guest, conn)
> +    cli.get_sound(options.sound, guest)

You want to skip this unless explicitly 'hvm' - paravirt Xen and
container based virt have no sound support.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|