[et-mgmt-tools] [PATCH 09 of 11] virt-convert: Add OS variant options

Cole Robinson crobinso at redhat.com
Mon Jul 14 16:50:12 UTC 2008


john.levon at sun.com wrote:
> # HG changeset patch
> # User john.levon at sun.com
> # Date 1215697571 25200
> # Node ID 443b42b45ee6f799020a9418388440b93d9ab78c
> # Parent  72eec78868efe7a872eab6c08502b3b84bf00a46
> virt-convert: Add OS variant options
> 
> And use them to set ACPI, APIC, clock, and USB tablet.
> 

I've committed this, though this brings to mind a few things
we should change before a next release. Just some thoughts:

Duplicating the internal OS dictionary in man pages isn't
helpful: we should just add a cli option to virt-install
(maybe all the tools that use the dict?) to dump the dictionary
in a readable manner and exit. That way the man pages can
just say 'see "virt-install --show-me-the-money" for a 
complete list.'

VMX files have a field which specifies the guest os: we should
probably try to translate that into an entry in the virtinst
OS dict if the user doesn't supply one.

Also I think the virt-image format should have an entry for
the OS type of the guest, so we should probably add this
option to virt-image as well.

Thanks,
Cole




More information about the et-mgmt-tools mailing list