[et-mgmt-tools] [PATCH] Fix Relax-NG pattern matching

[John Levon]

On Thu, Jul 24, 2008 at 01:46:32PM -0700, David Lutterkort wrote:

> Haven't checked myself, but are you sure that in the Relax-NG '.' and
> '+' retain their special meaning inside character classes ? In some

Yep:

xenbld:virt-convert $ grep '<name>' suse.hvm.virt-image.xml 
 <name>SUSE_Linux </name>
xenbld:virt-convert $ xmllint --relaxng doc/image.rng suse.hvm.virt-image.xml 2>&1  | grep 'Error validating'
xenbld:virt-convert $ vi doc/image.rng  # . -> \.
xenbld:virt-convert $ xmllint --relaxng doc/image.rng
suse.hvm.virt-image.xml 2>&1  | grep 'Error validating'
suse.hvm.virt-image.xml:3: element name: Relax-NG validity error : Error validating datatype string

> In any event, the '-' characters need to go at the very end of those
> character classes - that's definitely broken.

Are you sure about this?

      <param name="pattern">[A-Za-z0-9_\.\+\-:/]+</param>

...
       58 X     59 Y     5A Z     5B [     5C \     5D ]     5E ^    5F
...

$ grep '<name>' suse.hvm.virt-image.xml
 <name>SUSE_Linux-^</name>
$ xmllint --relaxng doc/image.rng suse.hvm.virt-image.xml 2>&1  | grep 'Error validating'
suse.hvm.virt-image.xml:3: element name: Relax-NG validity error : Error validating datatype string

It doesn't seem to be treating it as a range to me.

regards
john