[et-mgmt-tools] Re: [PATCH] cobbler buildiso add --systems option and fix --profiles selection.

[Joseph Boyer Jr.]

Very nice work!

Thanks!!

Cheers,
joe

Joseph Boyer Jr
Enterprise Technology Services
Liquidnet Holdings, Inc.
Joseph.Boyer at liquidnet.com
T   +1 646.660.8352
C   +1 646.284.8394

-----Original Message-----
From: et-mgmt-tools-bounces at redhat.com [mailto:et-mgmt-tools-bounces at redhat.com] On Behalf Of Dave Hatton
Sent: Wednesday, June 25, 2008 10:18 AM
To: et-mgmt-tools at redhat.com
Subject: [et-mgmt-tools] Re: [PATCH] cobbler buildiso add --systems option and fix --profiles selection.

Here is an updated patch for action_buildiso.py

I have run the diff against the original version of the program - would it be better against the version in git?

Changes:
1. Captured Joesphs changes to clean up images placed in iso - but I've left it to always include profiles and distros 2. I've changed "localboot 0/-1" option to use "KERNEL chain.32" with an "APPEND"
3. Modified to make sure chain.c32 is added to the image 4. Added code to remove the buildiso directory if it exists to make sure old files aren't kept around 5. Added a check and warning if APPEND line exceeds 250chars (think that could be 254?) 6. Incorporated Joesphs IP address fixes 7. Added a MENU SEPARATOR when adding systems

I have a new chain.c32 and a replacement isolinux.bin file to go in /var/lib/cobbler - should I send them to the ML?

Dave