[SPAM] Re: [et-mgmt-tools] [PATCH 1/1] Enhance mange_dns to optionally not (re)start bind

[Michael DeHaan]

Marcel Haerry wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi
>
>   
>> Thanks very much for the patch.   It turns out that the way this patch
>> is implemented exposes something I need to fix in cobbler -- namely,
>> manage_dhcp_mode and manage_dns_mode are no longer used.   Instead,
>> these modes are governed by modules.conf.
>>
>> So what we need to do is make this trigger access the modules system and
>> call the restart functions in those modules systems, and add two new
>> settings to the config file to govern whether or not DNS and DHCP
>> (respectively) are managed locally, and we add those to the trigger.
>>
>> Apologies for the confusion, these two settings in the code are dead and
>> I need to pull them out.   I'll do that now so I can apply what your
>> patch does as well as make something workable for 1.0.3.
>>     
>
>
> ah ok, I nearly thought that while looking at the modules.conf, however
> this was _after_ I implemented this patch, so I thought it might be
> worth a try to submit it.
> So thanks for your implementation or if you aren't doing it right now,
> it would be nice to have some advices how that should be. Is the isc
> mode already implented the modules way? Because from the
> manage_dhcp_mode I was cheating for my implementation.
>   

Your implementation would have worked just fine other than the 
manage_dhcp mode in settings
being pulled out.  

I should have my patch shortly and I'll post it to the list -- 
ordinarily I'd just let you do it, but this is a bit
confusing and I need to straighten it up.

ISC and DNS both go through modules.conf now.
They are enabled in 'settings', but how they are implemented is switched 
by the module loader.

I'm adding 'restart_dhcp' and 'restart_dns' presently and removing 
anything ending in "_mode".
I'm also fixing up the trigger.
> greets Marcel
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
>
> iEYEARECAAYFAkhijL8ACgkQxqnHThA4pEk6SACg0xVlLfw9mxJWw/jZG2MUmZN3
> euUAn0zWcSLDGyIiHcXIJCI0zIKMtUmq
> =4lpS
> -----END PGP SIGNATURE-----
>